[JENKINS-31162] Reviewed the ordening applied

jenkinsci · Mar 23, 2016 · f1f1565 · f1f1565
1 parent 2890ff3
commit f1f1565
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/core/src/main/java/jenkins/model/item_category/ItemCategory.java b/core/src/main/java/jenkins/model/item_category/ItemCategory.java
@@ -65,7 +65,7 @@ public int getWeight() {
      */
     @Nonnull
     public static ItemCategory getCategory(TopLevelItemDescriptor descriptor) {
-        int weight = 1;
+        int weight = 0;
         ExtensionList<ItemCategory> categories = ExtensionList.lookup(ItemCategory.class);
         for (ItemCategory category : categories) {
             if (category.getId().equals(descriptor.getCategoryId())) {

diff --git a/war/src/main/js/add-item.js b/war/src/main/js/add-item.js
@@ -170,9 +170,7 @@ $.when(getItems()).done(function(data){
     }
     function sortItemsByOrder(itemTypes) {
       function sortByOrder(a, b) {
-        var result = (a.weight - b.weight);
-        result = Math.max(result, -1); // If lt than -1, make it -1
-        result = Math.min(result, +1); // If gt than +1, make it +1
+        var result = (b.weight - a.weight);
         return result;
       }
       return itemTypes.sort(sortByOrder);