[JENKINS-33755] Added border in default icons

jenkinsci · Mar 30, 2016 · f071478 · f071478
1 parent e74075e
commit f071478
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/core/src/main/resources/hudson/model/View/newJob.jelly b/core/src/main/resources/hudson/model/View/newJob.jelly
@@ -40,7 +40,7 @@ THE SOFTWARE.
               <input name="name" id="name" placeholder="New item name..." type="text" />
               <div class="input-help">&#187; ${%ItemName.help}</div>
               <div id="itemname-required" class="input-validation-message input-message-disabled">&#187; ${%ItemName.validation.required}</div>
-              <div id="itemname-invalid" class="input-validation-message input-message-disabled">&#187; </div>
+              <div id="itemname-invalid" class="input-validation-message input-message-disabled"></div>
               <div id="itemtype-required" class="input-validation-message input-message-disabled">&#187; ${%ItemType.validation.required}</div>
             </div>
           </div>

diff --git a/war/src/main/js/add-item.js b/war/src/main/js/add-item.js
@@ -16,9 +16,6 @@ var jRoot = $('head').attr('data-rooturl');
 $.when(getItems()).done(function(data){
   $(function() {
 
-    // The main panel content is hidden by default via an inline style. We're ready to remove that now.
-    $('#add-item-panel').removeAttr('style');
-
     //////////////////////////
     // helper functions...
 
@@ -66,7 +63,7 @@ $.when(getItems()).done(function(data){
 
     function activateValidationMessage(messageId, context, message) {
       if (message !== undefined && message !== '') {
-        $(messageId, context).text(message);
+        $(messageId, context).html('&#187; ' + message);
       }
       cleanValidationMessages(context);
       hideInputHelp(context);
@@ -153,6 +150,9 @@ $.when(getItems()).done(function(data){
       return $icn;
     }
 
+    // The main panel content is hidden by default via an inline style. We're ready to remove that now.
+    $('#add-item-panel').removeAttr('style');
+
     // Render all categories
     var $categories = $('div.categories');
     $.each(data.categories, function(i, elem) {
@@ -162,7 +162,6 @@ $.when(getItems()).done(function(data){
     // Focus
     $("#add-item-panel").find("#name").focus();
 
-
     // Init NameField
     $('input[name="name"]', '#createItem').blur(function() {
       if (!isItemNameEmpty()) {

diff --git a/war/src/main/js/widgets/add/addform.less b/war/src/main/js/widgets/add/addform.less
@@ -166,7 +166,7 @@
   }
 
   .c-D33833 {
-    border-color: #900;
+    border: 1px solid #900;
     box-shadow:
       inset #900 0 0 1px,
       inset #fff 0 0 0 1px,
@@ -176,7 +176,7 @@
   }
 
   .c-6D6B6D {
-    border-color: #000;
+    border: 1px solid #000;
     box-shadow:
       inset #333 0 0 1px,
       inset #fff 0 0 0 1px,
@@ -186,7 +186,7 @@
   }
 
   .c-335061 {
-    border-color: #356;
+    border: 1px solid #356;
     box-shadow:
       inset #024 0 0 1px,
       inset #fff 0 0 0 1px,
@@ -196,7 +196,7 @@
   }
 
   .c-49728B {
-    border-color: #036;
+    border: 1px solid #036;
     box-shadow:
       inset #036 0 0 1px,
       inset #fff 0 0 0 1px,
@@ -206,7 +206,7 @@
   }
 
   .c-6699CC {
-    border-color: #6699cc;
+    border: 1px solid #6699cc;
     box-shadow:
       inset #003399 0 0 1px,
       inset #ffffff 0 0 0 1px,