Skip to content

Commit

Permalink
JENKINS-11013 NOT_BUILT & other build status are reported inconsistently
Browse files Browse the repository at this point in the history
The tooltip for the grey ball is "Pending" when it should be "Not built".
  • Loading branch information
oldelvet authored and kohsuke committed Sep 23, 2011
1 parent c2bdbd3 commit eea6d83
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions core/src/main/java/hudson/model/BallColor.java
Expand Up @@ -67,6 +67,8 @@ public enum BallColor implements StatusIcon {
DISABLED_ANIME("grey_anime",Messages._BallColor_InProgress(), ColorPalette.GREY),
ABORTED("grey",Messages._BallColor_Aborted(), ColorPalette.GREY),
ABORTED_ANIME("grey_anime",Messages._BallColor_InProgress(), ColorPalette.GREY),
NOTBUILT("grey",Messages._BallColor_NotBuilt(), ColorPalette.GREY),
NOTBUILT_ANIME("grey_anime",Messages._BallColor_InProgress(), ColorPalette.GREY),
;

private final Localizable description;
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/model/Result.java
Expand Up @@ -62,7 +62,7 @@ public final class Result implements Serializable, CustomExportedBean {
* This status code is used in a multi-stage build (like maven2)
* where a problem in earlier stage prevented later stages from building.
*/
public static final Result NOT_BUILT = new Result("NOT_BUILT",BallColor.GREY,3);
public static final Result NOT_BUILT = new Result("NOT_BUILT",BallColor.NOTBUILT,3);
/**
* The build was manually aborted.
*
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/model/Messages.properties
Expand Up @@ -70,6 +70,7 @@ BallColor.Aborted=Aborted
BallColor.Disabled=Disabled
BallColor.Failed=Failed
BallColor.InProgress=In progress
BallColor.NotBuilt=Not built
BallColor.Pending=Pending
BallColor.Success=Success
BallColor.Unstable=Unstable
Expand Down

0 comments on commit eea6d83

Please sign in to comment.