[FIXED JENKINS-19826] element.setAttribute('name', …) does not work i…

…n IE in compatibility mode, so use prototype’s Element(…) which does.
jenkinsci · Jan 7, 2014 · dda099c · dda099c
1 parent 7c91c40
commit dda099c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/changelog.html b/changelog.html
@@ -55,6 +55,9 @@
 <!-- Record your changes in the trunk here. -->
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
 <ul class=image>
+  <li class=bug>
+    <i>Apply</i> buttons did not work in Internet Explorer in compatibility mode.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-19826">issue 19826</a>)
   <li class=bug>
     <code>/login</code> offers link to <code>/opensearch.xml</code> which anonymous users cannot retrieve.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-21254">issue 21254</a>)

diff --git a/core/src/main/resources/lib/form/apply/apply.js b/core/src/main/resources/lib/form/apply/apply.js
@@ -29,10 +29,7 @@ Behaviour.specify("INPUT.apply-button", 'apply', 0, function (e) {
 
             // create a throw-away IFRAME to avoid back button from loading the POST result back
             id = "iframe"+(iota++);
-            target = document.createElement("iframe");
-            target.setAttribute("id",id);
-            target.setAttribute("name",id);
-            target.setAttribute("style","height:100%; width:100%");
+            target = Element('iframe', {id: id, name: id, style: 'height:100%; width:100%'});
             $(containerId).appendChild(target);
 
             attachIframeOnload(target, function () {
@@ -80,4 +77,4 @@ Behaviour.specify("INPUT.apply-button", 'apply', 0, function (e) {
                 f.target = null;
             }
         });
-});
+});