Merge pull request #1225 from synopsys-arc-oss/jenkins22693-inputstre…

…am-fix [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue
jenkinsci · Jun 1, 2014 · d2fb6d9 · d2fb6d9
2 parents e7ca7ae + 8767ddb
commit d2fb6d9
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/src/main/java/hudson/model/FileParameterValue.java b/core/src/main/java/hudson/model/FileParameterValue.java
@@ -257,7 +257,12 @@ public long getSize() {
 
         public byte[] get() {
             try {
-                return IOUtils.toByteArray(new FileInputStream(file));
+                FileInputStream inputStream = new FileInputStream(file);
+                try {
+                    return IOUtils.toByteArray(inputStream);
+                } finally {
+                    inputStream.close();
+                }
             } catch (IOException e) {
                 throw new Error(e);
             }
@@ -293,6 +298,7 @@ public boolean isFormField() {
         public void setFormField(boolean state) {
         }
 
+        @Deprecated
         public OutputStream getOutputStream() throws IOException {
             return new FileOutputStream(file);
         }