[JENKINS-15382] not sure which code is triggering animal sniffer viol…

…ation (cherry picked from commit f7671e6)
jenkinsci · Sep 17, 2013 · bcf9a84 · bcf9a84
1 parent fca0ea8
commit bcf9a84
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/core/src/main/java/hudson/tasks/junit/CaseResult.java b/core/src/main/java/hudson/tasks/junit/CaseResult.java
@@ -138,23 +138,23 @@ private static float parseTime(Element testCase) {
     }
 
     private static final int HALF_MAX_SIZE = 500;
-    static String possiblyTrimStdio(Collection<CaseResult> results, boolean keepLongStdio, CharSequence stdio) { // HUDSON-6516
+    static String possiblyTrimStdio(Collection<CaseResult> results, boolean keepLongStdio, String stdio) { // HUDSON-6516
         if (stdio == null) {
             return null;
         }
         if (!isTrimming(results, keepLongStdio)) {
-            return stdio.toString();
+            return stdio;
         }
         int len = stdio.length();
         int middle = len - HALF_MAX_SIZE * 2;
         if (middle <= 0) {
-            return stdio.toString();
+            return stdio;
         }
         return stdio.subSequence(0, HALF_MAX_SIZE) + "\n...[truncated " + middle + " chars]...\n" + stdio.subSequence(len - HALF_MAX_SIZE, len);
     }
 
     /**
-     * Flavor of {@link #possiblyTrimStdio(Collection, boolean, CharSequence)} that doesn't try to read the whole thing into memory.
+     * Flavor of {@link #possiblyTrimStdio(Collection, boolean, String)} that doesn't try to read the whole thing into memory.
      */
     static String possiblyTrimStdio(Collection<CaseResult> results, boolean keepLongStdio, File stdio) throws IOException {
         if (!isTrimming(results, keepLongStdio) && stdio.length()<1024*1024) {