Skip to content

Commit

Permalink
[JENKINS-16069] Remove wrapping of JSON with ( )
Browse files Browse the repository at this point in the history
now it is done properly on Javascript side so the current server
implementation triggers javascript errors.

Result can be observed on DynamicComboBox within ui-samples-plugin
  • Loading branch information
Vlatombe committed Dec 7, 2012
1 parent 87e2135 commit b6ce038
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changelog.html
Expand Up @@ -71,6 +71,9 @@
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-1295">issue 1295</a>)
<li class=bug>
Context menu and tooltip of the queue items were colliding with each other
<li class=bug>
Fix combobox ui component
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-16069">issue 16069</a>)
</ul>
</div><!--=TRUNK-END=-->

Expand Down
2 changes: 0 additions & 2 deletions core/src/main/java/hudson/util/ComboBoxModel.java
Expand Up @@ -62,8 +62,6 @@ public ComboBoxModel(String... values) {
public void generateResponse(StaplerRequest req, StaplerResponse rsp, Object node) throws IOException, ServletException {
rsp.setContentType(Flavor.JSON.contentType);
PrintWriter w = rsp.getWriter();
w.print('(');
JSONArray.fromObject(this).write(w);
w.print(')');
}
}

0 comments on commit b6ce038

Please sign in to comment.