[JENKINS-25601] Noting merge of #1499.

jenkinsci · Jan 9, 2015 · b33b921 · b33b921
2 parents 75eeccf + 1186e7b
commit b33b921
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/changelog.html b/changelog.html
@@ -61,6 +61,9 @@
   <li class=bug>
     Folder loading broken when child item loading throws exception.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-22811">issue 22811</a>)
+  <li class=bug>
+    Amend <code>JAVA_HOME</code> check to work with JDK 9.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-25601">issue 25601</a>)
   <li class=bug>
     Better support functional tests from Gradle-based plugins.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-26331">issue 26331</a>)

diff --git a/core/src/main/java/hudson/model/JDK.java b/core/src/main/java/hudson/model/JDK.java
@@ -182,7 +182,11 @@ public List<JDKInstaller> getDefaultInstallers() {
         @Override protected FormValidation checkHomeDirectory(File value) {
             File toolsJar = new File(value,"lib/tools.jar");
             File mac = new File(value,"lib/dt.jar");
-            if(!toolsJar.exists() && !mac.exists())
+
+            // JENKINS-25601: JDK 9+ no longer has tools.jar. Keep the existing dt.jar/tools.jar checks to be safe.
+            File javac = new File(value, "bin/javac");
+            File javacExe = new File(value, "bin/javac.exe");
+            if(!toolsJar.exists() && !mac.exists() && !javac.exists() && !javacExe.exists())
                 return FormValidation.error(Messages.Hudson_NotJDKDir(value));
 
             return FormValidation.ok();