[JENKINS-19457] Wrap eval in try-catch to prevent job configuration b…

…reakdown
jenkinsci · Sep 3, 2013 · afa517e · afa517e
1 parent 0e3c7a9
commit afa517e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js
@@ -413,7 +413,13 @@ function registerValidator(e) {
         var depends = this.getAttribute("checkDependsOn");
 
         if (depends==null) {// legacy behaviour where checkUrl is a JavaScript
-            return eval(url); // need access to 'this', so no 'geval'
+            try {
+            	return eval(url); // need access to 'this', so no 'geval'
+            } catch (e) {
+            	if (window.console!=null)  console.warn("Legacy checkUrl '" + url + "' is not valid Javascript: "+e);
+                if (window.YUI!=null)      YUI.log("Legacy checkUrl '" + url + "' is not valid Javascript: "+e,"warn");
+                return url; // return plain url as fallback
+            }
         } else {
             var q = qs(this).addThis();
             if (depends.length>0)