[JENKINS-19081] Testing the loadJSON method directly to make sure var…

…ious JSONP formats are handled. (cherry picked from commit fb52414)
jenkinsci · Apr 13, 2014 · a88fa41 · a88fa41
1 parent 7d6e02e
commit a88fa41
Show file tree

Hide file tree

Showing 3 changed files with 6,087 additions and 9 deletions.
diff --git a/test/src/test/java/hudson/model/DownloadServiceTest.java b/test/src/test/java/hudson/model/DownloadServiceTest.java
@@ -1,14 +1,17 @@
 package hudson.model;
 
 import hudson.model.DownloadService.Downloadable;
+import java.io.IOException;
+import java.net.URL;
+import java.util.Set;
+import java.util.TreeSet;
+import jenkins.security.DownloadSettings;
 import net.sf.json.JSONObject;
 import org.jvnet.hudson.test.Bug;
 import org.jvnet.hudson.test.HudsonTestCase;
+import org.jvnet.hudson.test.WithoutJenkins;
 import org.kohsuke.stapler.StaplerResponse;
 
-import java.io.IOException;
-import jenkins.security.DownloadSettings;
-
 /**
  * @author Kohsuke Kawaguchi
  */
@@ -21,18 +24,15 @@ public class DownloadServiceTest extends HudsonTestCase {
     @Override
     protected void setUp() throws Exception {
         super.setUp();
+        if (jenkins == null) {
+            return;
+        }
         // this object receives the submission.
         // to bypass the URL restriction, we'll trigger downloadService.download ourselves
         job = new Downloadable("test", "UNUSED");
         Downloadable.all().add(job);
     }
 
-    @Override
-    protected void tearDown() throws Exception {
-        Downloadable.all().remove(job);
-        super.tearDown();
-    }
-
     @Bug(5536)
     public void testPost() throws Exception {
         // initially it should fail because the data doesn't have a signature
@@ -60,4 +60,20 @@ public void doData(StaplerResponse rsp) throws IOException {
         rsp.setContentType("application/javascript");
         rsp.getWriter().println("downloadService.post('test',{'hello':"+hashCode()+"})");
     }
+
+    @WithoutJenkins // could have been in core/src/test/ but update-center.json was already in test/src/test/ (used by UpdateSiteTest)
+    public void testLoadJSON() throws Exception {
+        assertRoots("[list]", "hudson.tasks.Maven.MavenInstaller.json"); // format used by most tools
+        assertRoots("[data, version]", "hudson.tools.JDKInstaller.json"); // anomalous format
+        assertRoots("[connectionCheckUrl, core, id, plugins, signature, updateCenterVersion]", "update-center.json");
+    }
+
+    private static void assertRoots(String expected, String file) throws Exception {
+        URL resource = DownloadServiceTest.class.getResource(file);
+        assertNotNull(file, resource);
+        JSONObject json = JSONObject.fromObject(DownloadService.loadJSON(resource));
+        @SuppressWarnings("unchecked") Set<String> keySet = json.keySet();
+        assertEquals(expected, new TreeSet<String>(keySet).toString());
+    }
+
 }
diff --git a/test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller.json b/test/src/test/resources/hudson/model/hudson.tasks.Maven.MavenInstaller.json
@@ -0,0 +1,137 @@
+downloadService.post('hudson.tasks.Maven.MavenInstaller',{"list": [
+    {
+    "id": "3.1.1",
+    "name": "3.1.1",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.1.1-bin.zip"
+  },
+    {
+    "id": "3.1.0",
+    "name": "3.1.0",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.1.0-bin.zip"
+  },
+    {
+    "id": "3.0.5",
+    "name": "3.0.5",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.5-bin.zip"
+  },
+    {
+    "id": "3.0.4",
+    "name": "3.0.4",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip"
+  },
+    {
+    "id": "3.0.3",
+    "name": "3.0.3",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.3-bin.zip"
+  },
+    {
+    "id": "3.0.2",
+    "name": "3.0.2",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.2-bin.zip"
+  },
+    {
+    "id": "3.0.1",
+    "name": "3.0.1",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.1-bin.zip"
+  },
+    {
+    "id": "3.0",
+    "name": "3.0",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-3.0-bin.zip"
+  },
+    {
+    "id": "2.2.1",
+    "name": "2.2.1",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.2.1-bin.zip"
+  },
+    {
+    "id": "2.2.0",
+    "name": "2.2.0",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.2.0-bin.zip"
+  },
+    {
+    "id": "2.1.0",
+    "name": "2.1.0",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.1.0-bin.zip"
+  },
+    {
+    "id": "2.0.11",
+    "name": "2.0.11",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.11-bin.zip"
+  },
+    {
+    "id": "2.0.10",
+    "name": "2.0.10",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.10-bin.zip"
+  },
+    {
+    "id": "2.0.9",
+    "name": "2.0.9",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.9-bin.zip"
+  },
+    {
+    "id": "2.0.8",
+    "name": "2.0.8",
+    "url": "http://archive.apache.org/dist/maven/binaries/apache-maven-2.0.8-bin.zip"
+  },
+    {
+    "id": "2.0.7",
+    "name": "2.0.7",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.7-bin.zip"
+  },
+    {
+    "id": "2.0.6",
+    "name": "2.0.6",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.6-bin.zip"
+  },
+    {
+    "id": "2.0.5",
+    "name": "2.0.5",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.5-bin.zip"
+  },
+    {
+    "id": "2.0.4",
+    "name": "2.0.4",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.4-bin.zip"
+  },
+    {
+    "id": "2.0.3",
+    "name": "2.0.3",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.3-bin.zip"
+  },
+    {
+    "id": "2.0.2",
+    "name": "2.0.2",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.2-bin.zip"
+  },
+    {
+    "id": "2.0.1",
+    "name": "2.0.1",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0.1-bin.zip"
+  },
+    {
+    "id": "2.0",
+    "name": "2.0",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-2.0-bin.zip"
+  },
+    {
+    "id": "1.1",
+    "name": "1.1",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-1.1.zip"
+  },
+    {
+    "id": "1.0.2",
+    "name": "1.0.2",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-1.0.2.zip"
+  },
+    {
+    "id": "1.0.1",
+    "name": "1.0.1",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-1.0.1.zip"
+  },
+    {
+    "id": "1.0",
+    "name": "1.0",
+    "url": "http://archive.apache.org/dist/maven/binaries/maven-1.0.zip"
+  }
+]})