Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[JENKINS-36757] don't quote a paramaterized message in UpdateCenter. (#…
…2494)

'{0}' is the literal string {0} in a message format - if you want to quote
the parameter then you need to use double single quotes ''{0}''
(cherry picked from commit 03750c9)
  • Loading branch information
jtnord authored and olivergondza committed Aug 12, 2016
1 parent c3d15f9 commit 943d820
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion core/src/main/java/hudson/model/UpdateCenter.java
Expand Up @@ -1466,7 +1466,7 @@ public void run() {
}
});
} else {
LOGGER.log(WARNING, "Update site '{0}' does not declare the connection check URL. "
LOGGER.log(WARNING, "Update site ''{0}'' does not declare the connection check URL. "
+ "Skipping the network availability check.", site.getId());
connectionStates.put(ConnectionStatus.INTERNET, ConnectionStatus.SKIPPED);
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/jenkins/install/InstallState.java
Expand Up @@ -173,13 +173,13 @@ public void initializeState() {
public Object readResolve() {
// If we get invalid state from the configuration, fallback to unknown
if (StringUtils.isBlank(name)) {
LOGGER.log(Level.WARNING, "Read install state with blank name: '{0}'. It will be ignored", name);
LOGGER.log(Level.WARNING, "Read install state with blank name: ''{0}''. It will be ignored", name);
return UNKNOWN;
}

InstallState state = InstallState.valueOf(name);
if (state == null) {
LOGGER.log(Level.WARNING, "Cannot locate an extension point for the state '{0}'. It will be ignored", name);
LOGGER.log(Level.WARNING, "Cannot locate an extension point for the state ''{0}''. It will be ignored", name);
return UNKNOWN;
}

Expand Down
Expand Up @@ -24,4 +24,4 @@ Build\ scheduled=build agendada
delete=Excluir {0}
Configure=Configurar
View\ Configuration= Configurar a view
delete.confirm=Quer mesmo remover {0} '{1}'?
delete.confirm=Quer mesmo remover {0} ''{1}''?

0 comments on commit 943d820

Please sign in to comment.