[FIXED JENKINS-5460] Fix sort order of "diff" in Test Results

jenkinsci · Nov 7, 2011 · 89ddfc2 · 89ddfc2
1 parent 315395d
commit 89ddfc2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/changelog.html b/changelog.html
@@ -56,11 +56,14 @@
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
 <ul class=image>
   <li class=bug>
-  java.io.IOException: Unexpected termination of the channel - SEVERE: I/O error in channel Chunked connection when using jenkins-cli.jar (works on older Hudson version)
-  (<a href="https://issues.jenkins-ci.org/browse/JENKINS-11130">issue 11130</a>)
+    Sorting "diff" in test result requires 2 clicks
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-5460">issue 5460</a>)
+  <li class=bug>
+    java.io.IOException: Unexpected termination of the channel - SEVERE: I/O error in channel Chunked connection when using jenkins-cli.jar (works on older Hudson version)
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-11130">issue 11130</a>)
   <li class=rfe>
     Sortable table wasn't "stable" when there are same values in different rows
-  (<a href="https://issues.jenkins-ci.org/browse/JENKINS-11551">issue 11551</a>)
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-11551">issue 11551</a>)
 </ul>
 </div><!--=TRUNK-END=-->
 

diff --git a/core/src/main/resources/hudson/tasks/test/MetaTabulatedResult/body.jelly b/core/src/main/resources/hudson/tasks/test/MetaTabulatedResult/body.jelly
@@ -73,8 +73,8 @@ THE SOFTWARE.
             </div>
           </td>
 
-          <td class="pane" style="text-align:right;">
-            ${f.duration}
+          <td class="pane" style="text-align:right;" data="${f.duration}">
+            ${f.durationString}
           </td>
           <td class="pane" style="text-align:right;">
             <a href="${rootURL}/${f.failedSinceRun.url}">${f.age}</a>
@@ -110,15 +110,15 @@ THE SOFTWARE.
             </td>
             <td class="pane" style="text-align:right" data="${p.duration}">${p.durationString}</td>
             <td class="pane" style="text-align:right">${p.failCount}</td>
-            <td class="pane" style="text-align:right">
+            <td class="pane" style="text-align:right" data="${p.failCount-prev.failCount}">
               ${h.getDiffString2(p.failCount-prev.failCount)}
             </td>
             <td class="pane" style="text-align:right">${p.skipCount}</td>
-            <td class="pane" style="text-align:right">
+            <td class="pane" style="text-align:right" data="${p.skipCount-prev.skipCount}">
               ${h.getDiffString2(p.skipCount-prev.skipCount)}
             </td>
             <td class="pane" style="text-align:right">${p.totalCount}</td>
-            <td class="pane" style="text-align:right">
+            <td class="pane" style="text-align:right" data="${p.totalCount-prev.totalCount}">
               ${h.getDiffString2(p.totalCount-prev.totalCount)}
             </td>
           </tr>