Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing dir listing in test to not be case sensitive (related to JENKI…
- Loading branch information
Showing
1 changed file
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80f78d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wrong to me; subverts the intent of the test. If this was failing for you, the migration really was failing to work as expected.
User.getOrCreate
callsFile.renameTo
and so should be movingBob/
tobob/
. If this does not work on some platforms then it is the code which should be fixed, not the test.80f78d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And CC @stephenc since the test is to fix a problem in the migration he originally wrote.
80f78d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will amend this commit.