Commit
- Recorded the fix in changelog. - Added a separate screen to show the unmigration instruction, which makes it easier for people to find it than search logs.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<!-- | ||
The MIT License | ||
Copyright (c) 2014, CloudBees, Inc. | ||
Permission is hereby granted, free of charge, to any person obtaining a copy | ||
of this software and associated documentation files (the "Software"), to deal | ||
in the Software without restriction, including without limitation the rights | ||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
copies of the Software, and to permit persons to whom the Software is | ||
furnished to do so, subject to the following conditions: | ||
The above copyright notice and this permission notice shall be included in | ||
all copies or substantial portions of the Software. | ||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
THE SOFTWARE. | ||
--> | ||
|
||
<?jelly escape-by-default='true'?> | ||
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:i="jelly:fmt"> | ||
<l:layout title="Jenkins"> | ||
<l:header /> | ||
<l:main-panel> | ||
<p> | ||
To reverse the effect of <a href="http://jenkins-ci.org/issue/24380">JENKINS-24380</a> fix, run the following command | ||
on the server. See <a href="https://wiki.jenkins-ci.org/display/JENKINS/JENKINS-24380+Migration">Wiki page</a> | ||
for more details: | ||
</p> | ||
<table style="width:100%"> | ||
<tr> | ||
<td style="line-height:2em; width:80%"> | ||
<input type="text" value="${it.command}" style="width:100%"/> | ||
</td> | ||
<td style="line-height:2em"> | ||
<l:copyButton message="${%Copied}" text="${it.command}"/> | ||
</td> | ||
</tr> | ||
</table> | ||
</l:main-panel> | ||
</l:layout> | ||
</j:jelly> |
9 comments
on commit 711b332
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not hit users unprepared. While there's a bold changelog entry, there should be a post to the users list, and possibly a blog post about this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I'll ask @jglick to do a blog post on http://jenkins-ci.org/node/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if any blog content other than a link to the wiki (which I just edited BTW) is really needed.
There should be a link to the wiki in the server log message. Possibly this RootAction
should really be a AdministrativeMonitor
activated by the migration, with a page from which you can look at the instructions, or disable
the notice; WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making this an AdministrativeMonitor
is a great idea, however it should still be possible to reach the downgrade page even if dismissed once (i.e. use a real page with URL, not just the monitor notice).
There should be a link to the wiki in the server log message.
Perfect for users wondering why Jenkins takes so long to start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel strongly about how it should look, please file a blocking issue at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick From what you wrote this seems to be the plan already ("with a page from which you can look at the instructions").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what you wrote
Sorry, where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jglick The part I quoted. I asked for:
possible to reach the downgrade page even if dismissed once (i.e. use a real page with URL, not just the monitor notice).
You wrote:
with a page from which you can look at the instructions
Just wanted to emphasize that it really needs to be a separate page with its own URL, and not just in the AdministrativeMontor
's message.jelly
(which could be dismissed and lost forever).
This seems gratuitous. Why not just add the
permission
attribute tol:layout
?