[FIXED JENKINS-13378] Remove XML string writer from IOException2 when…

… XPath error occurs. Remove XML string writer from IOException2 message when XPath error occurs in /api/xml request. The XML string writer has the potential to be very large (many megabytes or even gigabytes) and these exceptions will be logged to the default jenkins logfile by winstone. This has the potential to quickly use all available disk space if, for example, a jenkins poller (i.e. a chrome extension) makes frequent calls to the API that cause errors.
jenkinsci · Apr 7, 2012 · 668a0cc · 668a0cc
1 parent 5432576
commit 668a0cc
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/core/src/main/java/hudson/model/Api.java b/core/src/main/java/hudson/model/Api.java
@@ -139,7 +139,7 @@ public void doXml(StaplerRequest req, StaplerResponse rsp,
             }
 
         } catch (DocumentException e) {
-            throw new IOException2("Failed to do XPath/wrapper handling. XML is as follows:"+sw,e);
+            throw new IOException2("Failed to do XPath/wrapper handling.",e);
         }
 
         OutputStream o = rsp.getCompressedOutputStream(req);