Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[JENKINS-16502] Permission to see an executor/slave
- This is an initial version of the feature. - The information about slave names is still exposed via label autocomplete
- Loading branch information
Showing
10 changed files
with
21 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
647695e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stephen,
I noticed that the tests hudson.bugs.JnlpAccessWithSecuredHudsonTest.testAnonymousCannotGetSecrets and hudson.bugs.JnlpAccessWithSecuredHudsonTest.testServiceUsingDirectSecret began to fail after this commit.
Both tests runs fine after add the line "hudson.model.Computer.View:anonymous" into the files test\src\main\preset-data\no-anonymous-readaccess\config.xml and test\src\main\preset-data\anonymous-readonly\config.xml. I don't know if this is the correct fix or if it's better change the tests instead.
If this kind of comments are suposed to be done in the dev-list, please tell me. I'm just new hacking jenkins.
Marcelo Rebasti
647695e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in
master
andrc
branches.647695e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider naming it
DISCOVER
in case there will be a new patch? Seems analogous toItem.DISCOVER
.647695e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olivergondza I do not think so;
DISCOVER
does not offer viewing permission, it merely allows you to distinguish a nonexistent job (404) from a job you cannot view (403).