[FIXED JENKINS-15487] Override put() method in RunMap

jlehtnie · kohsuke · commit 633e5c36b367 · 2012-12-09T22:27:20.000-08:00
Implementation according to Jesse Glick's comments on the issue.
diff --git a/changelog.html b/changelog.html
@@ -55,6 +55,9 @@
 <!-- Record your changes in the trunk here. -->
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
 <ul class=image>
+  <li class=bug>
+    Fixed <tt>java.lang.NoSuchMethodError: hudson.model.RunMap.put(Lhudson/model/Run;)Lhudson/model/Run;</tt>
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-15487">issue 15487</a>)
   <li class=bug>
     Saving the update center list after the metadata has been fetched results in 
     the metadata being persisted twice
diff --git a/core/src/main/java/hudson/model/RunMap.java b/core/src/main/java/hudson/model/RunMap.java
@@ -172,6 +172,11 @@ protected final String getIdOf(R r) {
         return r.getId();
     }
 
+    @Override
+    public R put(R r) {
+        return super._put(r);
+    }
+
     /**
      * Reuses the same reference as much as we can.
      * <p>
diff --git a/core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java b/core/src/main/java/jenkins/model/lazy/AbstractLazyLoadRunMap.java
@@ -502,7 +502,11 @@ public R getByNumber(int n) {
         return search(n,Direction.EXACT);
     }
 
-    public final R put(R value) {
+    public R put(R value) {
+        return _put(value);
+    }
+
+    protected R _put(R value) {
         return put(getNumberOf(value),value);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,11 @@ public R getByNumber(int n) {`
`502`	`502`	`return search(n,Direction.EXACT);`
`503`	`503`	`}`
`504`	`504`
`505`		`- public final R put(R value) {`
	`505`	`+ public R put(R value) {`
	`506`	`+ return _put(value);`
	`507`	`+ }`
	`508`	`+`
	`509`	`+ protected R _put(R value) {`
`506`	`510`	`return put(getNumberOf(value),value);`
`507`	`511`	`}`
`508`	`512`