[FIXED JENKINS-16682] getItem(name) can throw an AccessDeniedException

so iterate on itemGroup.getItems and filter by job names
jenkinsci · Feb 7, 2013 · 629b42a · 629b42a · jglick · Feb 7, 2013
1 parent cb07748
commit 629b42a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/core/src/main/java/hudson/model/ListView.java b/core/src/main/java/hudson/model/ListView.java
@@ -154,11 +154,11 @@ public List<TopLevelItem> getItems() {
 
         Boolean statusFilter = this.statusFilter; // capture the value to isolate us from concurrent update
         List<TopLevelItem> items = new ArrayList<TopLevelItem>(names.size());
-        for (String n : names) {
-            TopLevelItem item = getOwnerItemGroup().getItem(n);
+        for (TopLevelItem item : getOwnerItemGroup().getItems()) {
+            if (!names.contains(item.getName())) continue;
             // Add if no status filter or filter matches enabled/disabled status:
-            if(item!=null && (statusFilter == null || !(item instanceof AbstractProject)
-                              || ((AbstractProject)item).isDisabled() ^ statusFilter))
+            if(statusFilter == null || !(item instanceof AbstractProject)
+                              || ((AbstractProject)item).isDisabled() ^ statusFilter)
                 items.add(item);
         }