[JENKINS-31162] Another @jglick's comments were addressed

jenkinsci · Mar 21, 2016 · 5c10e57 · 5c10e57
1 parent 74b58dc
commit 5c10e57
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/core/src/main/java/hudson/model/ItemGroupMixIn.java b/core/src/main/java/hudson/model/ItemGroupMixIn.java
@@ -35,6 +35,8 @@
 import jenkins.model.Jenkins;
 import jenkins.util.xml.XMLUtils;
 import org.acegisecurity.Authentication;
+import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
 
@@ -341,6 +343,7 @@ public synchronized TopLevelItem createProject( TopLevelItemDescriptor type, Str
      *
      * @return A object that represents a set of {@link Category}
      */
+    @Restricted(NoExternalUse.class)
     public static Categories getCategories(Authentication a, ItemGroup c) {
         Categories categories = new Categories();
         int weight = 0;

diff --git a/core/src/main/java/jenkins/model/item_category/Categories.java b/core/src/main/java/jenkins/model/item_category/Categories.java
@@ -1,5 +1,7 @@
 package jenkins.model.item_category;
 
+import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.stapler.HttpResponse;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
@@ -21,6 +23,7 @@
  * This class is not thread-safe.
  */
 @ExportedBean
+@Restricted(NoExternalUse.class)
 public class Categories implements HttpResponse, Serializable {
 
     private List<Category> items;

diff --git a/core/src/main/java/jenkins/model/item_category/Category.java b/core/src/main/java/jenkins/model/item_category/Category.java
@@ -1,6 +1,8 @@
 package jenkins.model.item_category;
 
 import hudson.model.TopLevelItem;
+import org.kohsuke.accmod.Restricted;
+import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.stapler.export.Exported;
 import org.kohsuke.stapler.export.ExportedBean;
 
@@ -14,6 +16,7 @@
  * This class is not thread-safe.
  */
 @ExportedBean
+@Restricted(NoExternalUse.class)
 public class Category implements Serializable {
 
     private String id;