[JENKINS-15617]

This needs to be eval, not geval. Plus I forgot to return the value.
jenkinsci · Oct 25, 2012 · 5aca73f · 5aca73f
1 parent 51f508b
commit 5aca73f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js
@@ -369,7 +369,7 @@ function parseHtml(html) {
  */
 function geval(script) {
     // see http://perfectionkills.com/global-eval-what-are-the-options/
-    (this.execScript || eval)(script);
+    return (this.execScript || eval)(script);
 }
 
 /**
@@ -404,7 +404,7 @@ var tooltip;
 function registerValidator(e) {
     e.targetElement = findFollowingTR(e, "validation-error-area").firstChild.nextSibling;
     e.targetUrl = function() {
-        return geval(this.getAttribute("checkUrl"));
+        return eval(this.getAttribute("checkUrl")); // need access to 'this'
     };
     var method = e.getAttribute("checkMethod");
     if (!method) method = "get";