[JENKINS-7280] Touch-ups.

jenkinsci · May 23, 2013 · 53cbf59 · 53cbf59
1 parent 0c24848
commit 53cbf59
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/changelog.html b/changelog.html
@@ -58,6 +58,9 @@
   <li class=rfe>
     Enable word breaking in potentially long strings like job names.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-17030">issue 17030</a>)
+  <li class=rfe>
+    Allow filtering of the Run parameter build list by result.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-7280">issue 7280</a>)
   <li class=bug>
     “Recurse in subfolders” option for list views produced exceptions when used with native Maven projects.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-18025">issue 18025</a>)

diff --git a/core/src/main/java/hudson/model/RunParameterDefinition.java b/core/src/main/java/hudson/model/RunParameterDefinition.java
@@ -38,7 +38,8 @@
 public class RunParameterDefinition extends SimpleParameterDefinition {
 
     /**
-     * Constants that control how Run Parameter is filtered
+     * Constants that control how Run Parameter is filtered.
+     * @since 1.517
      */
     public enum RunParameterFilter {
         ALL,
@@ -59,6 +60,9 @@ public String getName() {
     private final String runId;
     private final RunParameterFilter filter;
 
+    /**
+     * @since 1.517
+     */
     @DataBoundConstructor
     public RunParameterDefinition(String name, String projectName, String description, RunParameterFilter filter) {
         super(name, description);
@@ -103,6 +107,7 @@ public Job getProject() {
 
     /**
      * @return The current filter value, if filter is null, returns ALL
+     * @since 1.517
      */
     public RunParameterFilter getFilter() {
     	// if filter is null, default to RunParameterFilter.ALL

diff --git a/core/src/main/java/hudson/util/RunList.java b/core/src/main/java/hudson/util/RunList.java
@@ -241,9 +241,9 @@ public boolean apply(R r) {
     }
 
     /**
-     * Filter the list to builds >= threshold.
+     * Filter the list to builds above threshold.
      * 
-     * @since 1.516
+     * @since 1.517
      */
     public RunList<R> overThresholdOnly(final Result threshold) {
         return filter(new Predicate<R>() {

diff --git a/test/src/test/java/hudson/model/RunParameterDefinitionTest.java b/test/src/test/java/hudson/model/RunParameterDefinitionTest.java
@@ -238,7 +238,7 @@ public void testSTABLEFilter() throws Exception {
 
     static class ResultPublisher extends Publisher {
 
-        private Result result = Result.FAILURE;
+        private final Result result;
 
         public ResultPublisher(Result result) {
             this.result = result;