Skip to content

Commit

Permalink
[FIXED JENKINS-13564] If there is any problem when searching for user…
Browse files Browse the repository at this point in the history
… partipication in the build, end up more gracefully.
  • Loading branch information
vjuranek committed Apr 24, 2012
1 parent 4eb17c1 commit 4f272d4
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions core/src/main/java/hudson/model/AbstractBuild.java
Expand Up @@ -359,8 +359,13 @@ public int size() {
*/
public boolean hasParticipant(User user) {
for (ChangeLogSet.Entry e : getChangeSet())
if (e.getAuthor()==user)
return true;
try{
if (e.getAuthor()==user)
return true;
} catch (RuntimeException re) {
// no-op, just remove exception thrown e.g. from git plugin.

This comment has been minimized.

Copy link
@kutzi

kutzi May 12, 2012

Member

Shouldn't we at least log the exception? Otherwise one might never notice, if there's a bug in a SCM plugin

This comment has been minimized.

Copy link
@vjuranek

vjuranek Jul 16, 2012

Author Member

Sorry, I somehow missed this comment. You are right, fixed in 76ac10d

// It there's some problem to determine committer, user probably doesn't participate in the build.
}
return false;
}

Expand Down

0 comments on commit 4f272d4

Please sign in to comment.