[FIXED JENKINS-13536] Using file parameters could cause build records…

… to not load. Solves the issue for newly created builds by not attempting to persist the original file upload record, which is useless after the build has run (the fileParameters dir in the build already archives them). Does not help loading pre-fix builds in which the upload temp file has been deleted; for these, you must manually delete <file class="org.apache.commons.fileupload.disk.DiskFileItem" serialization="custom">…</file> from the build.xml. (Did not find a straightforward way to just instruct XStream to ignore this bit of XML: it is easy to avoid serializing a field, but deserializing is different.)
jenkinsci · Dec 3, 2012 · 4dde24e · 4dde24e
1 parent b53d0bf
commit 4dde24e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.html b/changelog.html
@@ -55,6 +55,9 @@
 <!-- Record your changes in the trunk here. -->
 <div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
 <ul class=image>
+  <li class=bug>
+    Using file parameters could cause build records to not load.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-13536">issue 13536</a>)
   <li class=bug>
     Possible race condition in RemoteClassLoader renders slave unusable.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-6604">issue 6604</a>)

diff --git a/core/src/main/java/hudson/model/FileParameterValue.java b/core/src/main/java/hudson/model/FileParameterValue.java
@@ -59,7 +59,7 @@
  * @author Kohsuke Kawaguchi
  */
 public class FileParameterValue extends ParameterValue {
-    private final FileItem file;
+    private transient final FileItem file;
 
     /**
      * The name of the originally uploaded file.