Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[FIXED JENKINS-22247] Noting merge of #1161.
  • Loading branch information
jglick committed May 22, 2014
1 parent ef949ee commit 484db6b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 13 deletions.
3 changes: 3 additions & 0 deletions changelog.html
Expand Up @@ -55,6 +55,9 @@
<!-- Record your changes in the trunk here. -->
<div id="trunk" style="display:none"><!--=TRUNK-BEGIN=-->
<ul class=image>
<li class="rfe">
Configurable case sensitivity mode for user IDs.
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-22247">issue 22247</a>)
<li class="bug">
Extension point for project naming strategies did not work from actual plugins.
(<a href="https://issues.jenkins-ci.org/browse/JENKINS-23127">issue 23127</a>)
Expand Down
5 changes: 2 additions & 3 deletions core/src/main/java/hudson/model/User.java
Expand Up @@ -133,7 +133,7 @@ private User(String id, String fullName) {
* {@link hudson.security.SecurityRealm#getUserIdStrategy()}
*
* @return the {@link jenkins.model.IdStrategy} for use with {@link User} instances.
* @since 1.560
* @since 1.566
*/
@Nonnull
public static IdStrategy idStrategy() {
Expand Down Expand Up @@ -497,7 +497,7 @@ public static void clear() {

/**
* Called when changing the {@link IdStrategy}.
* @since 1.560
* @since 1.566
*/
public static void rekey() {
final IdStrategy strategy = idStrategy();
Expand Down Expand Up @@ -712,7 +712,6 @@ private void rss(StaplerRequest req, StaplerResponse rsp, String suffix, RunList
* {@link java.util.concurrent.locks.ReadWriteLock#readLock()} for normal access and
* {@link java.util.concurrent.locks.ReadWriteLock#writeLock()} for {@link #rekey()} or any other operation
* that requires operating on the map as a whole.
* @since 1.560
*/
private static final ReadWriteLock byNameLock = new ReentrantReadWriteLock();

Expand Down
4 changes: 2 additions & 2 deletions core/src/main/java/hudson/security/SecurityRealm.java
Expand Up @@ -156,7 +156,7 @@ public abstract class SecurityRealm extends AbstractDescribableImpl<SecurityReal
*
* @return the {@link IdStrategy} that should be used for turning
* {@link org.acegisecurity.userdetails.UserDetails#getUsername()} into an ID.
* @since 1.560
* @since 1.566
*/
public IdStrategy getUserIdStrategy() {
return IdStrategy.CASE_INSENSITIVE;
Expand All @@ -170,7 +170,7 @@ public IdStrategy getUserIdStrategy() {
*
* @return the {@link IdStrategy} that should be used for turning {@link hudson.security.GroupDetails#getName()}
* into an ID.
* @since 1.560
* @since 1.566
*/
public IdStrategy getGroupIdStrategy() {
return getUserIdStrategy();
Expand Down
8 changes: 1 addition & 7 deletions core/src/main/java/jenkins/model/IdStrategy.java
Expand Up @@ -37,7 +37,7 @@
/**
* The strategy to use for manipulating converting names (e.g. user names, group names, etc) into ids.
*
* @since 1.560
* @since 1.566
*/
public abstract class IdStrategy extends AbstractDescribableImpl<IdStrategy> implements ExtensionPoint,
Comparator<String> {
Expand Down Expand Up @@ -135,8 +135,6 @@ public static DescriptorExtensionList<IdStrategy, IdStrategyDescriptor> all() {

/**
* The default case insensitive {@link IdStrategy}
*
* @since 1.560
*/
public static class CaseInsensitive extends IdStrategy {

Expand Down Expand Up @@ -177,8 +175,6 @@ public String getDisplayName() {

/**
* A case sensitive {@link IdStrategy}
*
* @since 1.560
*/
public static class CaseSensitive extends IdStrategy {

Expand Down Expand Up @@ -256,8 +252,6 @@ public String getDisplayName() {
* Note: Not all email addresses are case sensitive. It is knowledge that belongs to the server that holds the
* mailbox. Most sane system administrators do not configure their accounts using case sensitive mailboxes
* but the RFC does allow them the option to configure that way. Domain names are always case insensitive per RFC.
*
* @since 1.560
*/
public static class CaseSensitiveEmailAddress extends CaseSensitive {

Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/jenkins/model/IdStrategyDescriptor.java
Expand Up @@ -28,7 +28,7 @@
/**
* The {@link hudson.model.Descriptor} for {@link jenkins.model.IdStrategy}
*
* @since 1.560
* @since 1.566
*/
public abstract class IdStrategyDescriptor extends Descriptor<IdStrategy> {

Expand Down

0 comments on commit 484db6b

Please sign in to comment.