[FIXES JENKINS-15976] After de-serializing changed job settings after…

… "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization.
jenkinsci · Jul 3, 2013 · 40f3b09 · 40f3b09
1 parent 184b4a9
commit 40f3b09
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/core/src/main/java/hudson/tasks/Maven.java b/core/src/main/java/hudson/tasks/Maven.java
@@ -435,10 +435,7 @@ public void setInstallations(MavenInstallation... installations) {
 
         @Override
         public Builder newInstance(StaplerRequest req, JSONObject formData) throws FormException {
-            Maven m = req.bindJSON(Maven.class,formData);
-            m.setSettings(GlobalMavenConfig.get().getSettingsProvider());
-            m.setGlobalSettings(GlobalMavenConfig.get().getGlobalSettingsProvider());
-            return m;
+            return req.bindJSON(Maven.class,formData);
         }
     }