[JENKINS-26781] set $class in submitted form to use descriptor.id, so…

… descriptor can be retrieved by ID, which _may_ not be clazz.name
jenkinsci · Feb 4, 2015 · 3edce88 · 3edce88
1 parent a944634
commit 3edce88
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/src/main/java/hudson/model/Descriptor.java b/core/src/main/java/hudson/model/Descriptor.java
@@ -918,6 +918,7 @@ List<T> newInstancesFromHeteroList(StaplerRequest req, Object formData,
                 if (d != null) {
                     items.add(d.newInstance(req, jo));
                 }
+                LOGGER.warning("Received unexpected formData for descriptor " + kind);
             }
         }
 

diff --git a/core/src/main/resources/lib/form/class-entry.jelly b/core/src/main/resources/lib/form/class-entry.jelly
@@ -34,7 +34,7 @@ THE SOFTWARE.
       structured form submission.  Mutually exclusive with clazz.
     </st:attribute>
   </st:documentation>
-  <j:set var="clazz" value="${attrs.clazz ?: attrs.descriptor.clazz.name}" />
+  <j:set var="clazz" value="${attrs.clazz ?: attrs.descriptor.id}" />
   <f:invisibleEntry>
     <!-- Legacy: Remove once plugins have been staged onto $class -->
     <input type="hidden" name="stapler-class" value="${clazz}" />