[JENKINS-34464] Switch ReverseBuildTrigger.threshold to DataBoundSetter

jenkinsci · May 22, 2017 · 3b712af · 3b712af
1 parent df21a13
commit 3b712af
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java b/core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
@@ -73,6 +73,7 @@
 import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
+import org.kohsuke.stapler.DataBoundSetter;
 import org.kohsuke.stapler.QueryParameter;
 
 import javax.annotation.Nonnull;
@@ -91,12 +92,11 @@ public final class ReverseBuildTrigger extends Trigger<Job> implements Dependenc
     private static final Logger LOGGER = Logger.getLogger(ReverseBuildTrigger.class.getName());
 
     private String upstreamProjects;
-    private final Result threshold;
+    private Result threshold = Result.SUCCESS;
 
     @DataBoundConstructor
-    public ReverseBuildTrigger(String upstreamProjects, Result threshold) {
+    public ReverseBuildTrigger(String upstreamProjects) {
         this.upstreamProjects = upstreamProjects;
-        this.threshold = threshold;
     }
 
     public String getUpstreamProjects() {
@@ -107,6 +107,11 @@ public Result getThreshold() {
         return threshold;
     }
 
+    @DataBoundSetter
+    public void setThreshold(Result r) {
+        this.threshold = r;
+    }
+
     private boolean shouldTrigger(Run upstreamBuild, TaskListener listener) {
         Jenkins jenkins = Jenkins.getInstance();
         if (job == null) {