[FIXED JENKINS-26476] Work around Remoting problem by avoiding refere…

…nce to Functions.
jenkinsci · Jan 16, 2015 · 36bce39 · 36bce39
1 parent c8806c9
commit 36bce39
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/core/src/main/java/hudson/FilePath.java b/core/src/main/java/hudson/FilePath.java
@@ -1581,6 +1581,7 @@ public void chmod(final int mask) throws IOException, InterruptedException {
         act(new SecureFileCallable<Void>() {
             private static final long serialVersionUID = 1L;
             public Void invoke(File f, VirtualChannel channel) throws IOException {
+                // TODO first check for Java 7+ and use PosixFileAttributeView
                 _chmod(writing(f), mask);
 
                 return null;
@@ -1592,7 +1593,9 @@ public Void invoke(File f, VirtualChannel channel) throws IOException {
      * Run chmod via jnr-posix
      */
     private static void _chmod(File f, int mask) throws IOException {
-        if (Functions.isWindows())  return; // noop
+        // TODO WindowsPosix actually does something here (WindowsLibC._wchmod); should we let it?
+        // Anyway the existing calls already skip this method if on Windows.
+        if (File.pathSeparatorChar==';')  return; // noop
 
         PosixAPI.jnr().chmod(f.getAbsolutePath(),mask);
     }