[FIXED JENKINS-9822] occasional NPE when running maven jobs

jenkinsci · Jul 16, 2011 · 345b3bb · 345b3bb · mfriedenhagen · Jul 26, 2011
1 parent ff3d287
commit 345b3bb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/changelog.html b/changelog.html
@@ -58,6 +58,9 @@
   <li class=bug>
     Fixed a race condition in the fingerprint computation 
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-10346">issue 10346</a>)
+  <li class=bug>
+    Fixed an occasional NPE when running Maven jobs 
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-9822">issue 9822</a>)
 </ul>
 </div><!--=TRUNK-END=-->
 

diff --git a/maven-plugin/src/main/java/hudson/maven/MavenBuild.java b/maven-plugin/src/main/java/hudson/maven/MavenBuild.java
@@ -540,7 +540,7 @@ public void end() {
         }
 
         /**
-         * Sends the accumuldated log in {@link SplittableBuildListener} to the log of this build.
+         * Sends the accumulated log in {@link SplittableBuildListener} to the log of this build.
          */
         public void appendLastLog() {
             try {
@@ -586,6 +586,11 @@ public void cleanUp(BuildListener listener) {
         private void rememberModulesToBuildAgainNextTime() {
             MavenModuleSetBuild moduleSetBuild = getModuleSetBuild();
 
+            if (moduleSetBuild == null) {
+                // ModuleSetBuild is gone, for whatever reason JENKINS-9822
+                return;
+            }
+
             if(hasntStartedYet()) {
                 // record modules which have not been build though they should have - i.e. because they
                 // have SCM changes.