[JENKINS-18898] Comment.

Unclear what Run.getEnvironment is supposed to return after the build is complete. In particular, SubversionSCM calls this during polling to substitute variables in e.g. repo URL. Presumably in such a case node-specific variables such as ToolInstallation.home would be irrelevant. But in general should this reflect the “current” computer (if any), or the computer on which the build ran?
jenkinsci · Jul 24, 2013 · 33101a3 · 33101a3
1 parent be158b4
commit 33101a3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java b/maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
@@ -172,7 +172,7 @@ public EnvVars getEnvironment(TaskListener log) throws IOException, InterruptedE
 
         Computer computer = Computer.currentComputer();
         if (computer != null) { // just in case were not in a build
-            Node node = computer.getNode();
+            Node node = computer.getNode(); // TODO should this rather be getBuiltOn()? Cf. JENKINS-18898
             if (node != null) {
                 mvn = mvn.forNode(node, log);
                 mvn.buildEnvVars(envs);