[CID-1205053] - Resource leak on fingerprint calculation in Directory…

…BrowserSupport The issue is related to JENKINS-18351. Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
jenkinsci · Nov 4, 2014 · 2ea0276 · 2ea0276 · daniel-beck · Nov 4, 2014
1 parent 21ba31a
commit 2ea0276
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/core/src/main/java/hudson/model/DirectoryBrowserSupport.java b/core/src/main/java/hudson/model/DirectoryBrowserSupport.java
@@ -284,7 +284,12 @@ private void serveFile(StaplerRequest req, StaplerResponse rsp, VirtualFile root
         boolean view = rest.equals("*view*");
 
         if(rest.equals("*fingerprint*")) {
-            rsp.forward(Jenkins.getInstance().getFingerprint(Util.getDigestOf(baseFile.open())), "/", req);
+            InputStream fingerprintInput = baseFile.open();
+            try {
+                rsp.forward(Jenkins.getInstance().getFingerprint(Util.getDigestOf(fingerprintInput)), "/", req);
+            } finally {
+                fingerprintInput.close();
+            }
             return;
         }