[JENKINS-16979] Migrated test from Groovy to Java for ease of mainten…

…ance.
jenkinsci · Nov 13, 2015 · 2200711 · 2200711
1 parent 1151be4
commit 2200711
Show file tree

Hide file tree

Showing 4 changed files with 71 additions and 49 deletions.
diff --git a/test/src/test/groovy/jenkins/model/BuildDiscarderTest.groovy b/test/src/test/groovy/jenkins/model/BuildDiscarderTest.groovy
diff --git a/test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java b/test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java
@@ -0,0 +1,71 @@
+/*
+ * The MIT License
+ *
+ * Copyright 2015 CloudBees, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package jenkins.model;
+
+import hudson.model.AbstractProject;
+import hudson.tasks.LogRotator;
+import java.io.StringReader;
+import javax.xml.transform.Source;
+import javax.xml.transform.stream.StreamSource;
+import org.junit.Test;
+import static org.junit.Assert.*;
+import org.junit.Rule;
+import org.jvnet.hudson.test.Issue;
+import org.jvnet.hudson.test.JenkinsRule;
+import org.jvnet.hudson.test.recipes.LocalData;
+
+public class BuildDiscarderPropertyTest {
+
+    @Rule
+    public JenkinsRule r = new JenkinsRule();
+
+    @Issue("JENKINS-16979")
+    @LocalData
+    @Test
+    public void logRotatorField() throws Exception {
+        AbstractProject<?,?> p = r.jenkins.getItemByFullName("foo", AbstractProject.class);
+        verifyLogRotatorSanity(p);
+
+        // now persist in the new format
+        p.save();
+        String xml = p.getConfigFile().asString();
+
+        // make sure this new format roundtrips by itself
+        p.setBuildDiscarder(null);
+        p.updateByXml((Source) new StreamSource(new StringReader(xml)));
+        verifyLogRotatorSanity(p);
+
+        // another sanity check
+        assertTrue(xml, xml.contains("<logRotator class=\"" + LogRotator.class.getName() + "\">"));
+    }
+
+    private static void verifyLogRotatorSanity(AbstractProject<?,?> p) {
+        LogRotator d = (LogRotator) p.getBuildDiscarder();
+        assertEquals(4, d.getDaysToKeep());
+        assertEquals(3, d.getNumToKeep());
+        assertEquals(2, d.getArtifactDaysToKeep());
+        assertEquals(1, d.getArtifactNumToKeep());
+    }
+}
diff --git a/...ildDiscarderTest/compatibility/config.xml → ...erPropertyTest/logRotatorField/config.xml b/...ildDiscarderTest/compatibility/config.xml → ...erPropertyTest/logRotatorField/config.xml
diff --git a/...derTest/compatibility/jobs/foo/config.xml → ...yTest/logRotatorField/jobs/foo/config.xml b/...derTest/compatibility/jobs/foo/config.xml → ...yTest/logRotatorField/jobs/foo/config.xml