[FIXED JENKINS-22080] Braindead logic in author of original fix... co…

…rrected by same author (cherry picked from commit 483181c)
jenkinsci · Apr 13, 2014 · 18e5415 · 18e5415
1 parent 94fd597
commit 18e5415
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java
@@ -695,10 +695,13 @@ public void doInstall(StaplerRequest req, StaplerResponse rsp) throws IOExceptio
                     String siteName = n.substring(index + 1);
                     UpdateSite updateSite = Jenkins.getInstance().getUpdateCenter().getById(siteName);
                     if (siteName != null) {
-                        if (p != null) {
-                            throw new Failure("Ambiguous plugin: " + n);
+                        UpdateSite.Plugin plugin = updateSite.getPlugin(pluginName);
+                        if (plugin != null) {
+                            if (p != null) {
+                                throw new Failure("Ambiguous plugin: " + n);
+                            }
+                            p = plugin;
                         }
-                        p = updateSite.getPlugin(pluginName);
                     }
                     index = n.indexOf('.', index + 1);
                 }