[JENKINS-19081] Be a bit paranoid and ensure the admin has CONFIGURE_…

…UPDATECENTER before turning off signature checks. (cherry picked from commit 1262d88)
jenkinsci · Apr 13, 2014 · 09af03a · 09af03a
1 parent d842aa4
commit 09af03a
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/core/src/main/java/jenkins/security/DownloadSettings.java b/core/src/main/java/jenkins/security/DownloadSettings.java
@@ -25,6 +25,7 @@
 package jenkins.security;
 
 import hudson.Extension;
+import hudson.PluginManager;
 import hudson.model.AsyncPeriodicWork;
 import hudson.model.DownloadService;
 import hudson.model.TaskListener;
@@ -84,6 +85,11 @@ public boolean isCheckSignature() {
     }
 
     public void setCheckSignature(boolean checkSignature) {
+        if (!checkSignature) {
+            // Just to be on the safe side. Normally this is implied by ADMINISTER, needed to configure the security screen anyway,
+            // but in case ADMINISTER but not CONFIGURE_UPDATECENTER is somehow granted, make sure signature checking cannot be disabled.
+            Jenkins.getInstance().checkPermission(PluginManager.CONFIGURE_UPDATECENTER);
+        }
         this.checkSignature = checkSignature;
         save();
     }