Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[JENKINS-43786] Addressed suggestions from @vilacides, @amuniz and @f…
  • Loading branch information
recena committed Jan 15, 2018
1 parent d174c8b commit acba131
Showing 1 changed file with 8 additions and 8 deletions.
Expand Up @@ -10,16 +10,16 @@ author: recena

== Overview

Recently some UI improvements around to the Manage Jenkins page have been introduced. The visual changes are very subtle but behind of them, there are interesting benefits.
Recently some UI improvements around the Manage Jenkins page have been introduced. The visual changes are very subtle but behind of them, there are interesting benefits.

Some of the goals that we have tried to achieve:

* Applying a https://en.wikipedia.org/wiki/Semantic_HTML[semantic HTML]
* Removing the `<table>` tag usage for implementing layouts and content structures. Read this https://www.hotdesign.com/seybold[article] if you want to know reasons and / or arguments.
* Removing the `<table>` tag usage for implementing layouts and content structures. Read this https://www.hotdesign.com/seybold[article] if you want to know reasons and/or arguments.
* Small re-styling focused on spacing, margins, composition, etc..
* Accesibility
* Accessibility

In order to provide a quick view of the visual changes, let's take a look at these screenshots.
In order to provide a quick overview of the visual changes, let's take a look at these screenshots.

=== System tray with administrative messages (before)

Expand All @@ -37,11 +37,11 @@ image:/images/post-images/2018-01-15-JENKINS-43786/JENKINS-43786_4-before.png[ro

image:/images/post-images/2018-01-15-JENKINS-43786/JENKINS-43786_1.png[role="center"]

Information about how this change can affect to the current implementations of https://jenkins.io/doc/developer/extensions/jenkins-core/#administrativemonitor[Administrative Monitors] can be found in the following section
Information about how this change can affect the current implementation of https://jenkins.io/doc/developer/extensions/jenkins-core/#administrativemonitor[Administrative Monitors] can be found in the following section

== For core developers

Let's use an real example for showing how this proposal works.
Let's use a real example for showing how this proposal works.

This is the original UI implementation of `HudsonHomeDiskUsageMonitor.java`:

Expand Down Expand Up @@ -87,7 +87,7 @@ All administrative monitors defined in Jenkins core have been adapted as part of

== For plugin developers

No change are _really_ needed, but we do recommend you to adapt your plugins to this proposal so Jenkins users have a better user experience.
No changes are _really_ needed, but we do recommend you to adapt your plugins to this proposal so Jenkins users have a better user experience.

Taking into account that you want to keep backward compatibility, you will need some changes.

Expand All @@ -109,7 +109,7 @@ In your implementation of https://jenkins.io/doc/developer/extensions/jenkins-co
}
----

In your view (a.k.a. Jelly file):
In your view (a.k.a. Jelly file or Groovy file):

[source,html]
----
Expand Down

0 comments on commit acba131

Please sign in to comment.