[Fix JENKINS-16632] Don't print auth stack traces.

Really fix JENKINS-16632. We cannot print the AuthorizationException stack trace because it contains private auth info and printing the stack trace writes it to the Jenkins build console log. Instead catch AuthorizationExceptions then create a new RuntimeException whose message can be printed. Print the RuntimeException stack trace and a helpful message that authorization failed.
jenkinsci · Feb 25, 2013 · 8b55b2f · 8b55b2f
1 parent 01991c6
commit 8b55b2f
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/main/java/jenkins/plugins/jclouds/blobstore/BlobStorePublisher.java b/src/main/java/jenkins/plugins/jclouds/blobstore/BlobStorePublisher.java
@@ -161,7 +161,9 @@ public boolean perform(AbstractBuild<?, ?> build,
          }
       } catch (AuthorizationException e) {
          LOGGER.severe("Failed to upload files to Blob Store due to authorization exception.");
-         e.printStackTrace(listener.error("Failed to upload files"));
+         RuntimeException overrideException =
+            new RuntimeException("Failed to upload files to Blob Store due to authorization exception.");
+         overrideException.printStackTrace(listener.error("Failed to upload files"));
          build.setResult(Result.UNSTABLE);
       } catch (IOException e) {
          LOGGER.severe("Failed to upload files to Blob Store: " + e.getMessage());