Skip to content

Commit

Permalink
JENKINS-23623: Fix URL in JaCoCo Coverage Column in non-default views…
Browse files Browse the repository at this point in the history 
…, works around JENKINS-25113
  • Loading branch information
@centic9
centic9 committed Oct 11, 2014
1 parent f2e97e9 commit 44b5d29
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/resources/hudson/plugins/jacococoveragecolumn/JaCoCoColumn/column.jelly
View file
Expand Up @@ -19,7 +19,7 @@
data="${coverageAmount}" align="center">
<j:choose>
<j:when test="${it.hasCoverage(job)}">
<a style="color:#${color}" href="${job.url}lastSuccessfulBuild/jacoco/">
<a style="color:#${color}" href="${jobBaseUrl}${job.shortUrl}lastSuccessfulBuild/jacoco/">
${coveragePercent}%
</a>
</j:when>
Expand Down

3 comments on commit 44b5d29

@jglick
Copy link
Member

@jglick jglick commented on 44b5d29 Oct 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See jenkinsci/cobertura-plugin@1a89911; I would suggest you try

href="${rootURL}/${job.url}lastSuccessfulBuild/jacoco/"

instead.

@centic9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip, I adjusted it accordingly. I was looking at some other plugins and took it from there, seems usage of these URL-variables is still a bit inconsistent across plugins.

@jglick
Copy link
Member

@jglick jglick commented on 44b5d29 Oct 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I plan to fix the variant used in core to serve as a better model.

Please sign in to comment.