[FIXED JENKINS-15469]: shouldn't call save() in readResolve() as that…

… will fail on Windows
jenkinsci · Oct 13, 2012 · 7db3a61 · 7db3a61
1 parent 116867b
commit 7db3a61
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/hudson/plugins/ircbot/IrcPublisher.java b/src/main/java/hudson/plugins/ircbot/IrcPublisher.java
@@ -507,7 +507,6 @@ private Object readResolve() {
 					}
 
 					this.channels = null;
-					save();
 				}
 			}
 
@@ -519,7 +518,10 @@ private Object readResolve() {
 			    this.password = Scrambler.scramble(this.password);
 			    this.nickServPassword = Scrambler.scramble(this.nickServPassword);
 			    this.scrambledPasswords = true;
-			    save();
+			    // JENKINS-15469: seems to be a bad idea to save in readResolve
+			    // as the file to be saved/replaced is currently open for reading and thus
+			    // save() will fail on Windows
+			    //save();
 			}
 
 			return this;