Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[FIXED JENKINS-17017] PircBotX#connect() sometimes fails with Runtime…
…Excpetion - which is not exactly what the Javadoc says
  • Loading branch information
kutzi committed Mar 1, 2013
1 parent 5e23f7a commit 3f3a6bd
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
Expand Up @@ -164,6 +164,10 @@ public boolean connect() {
LOGGER.warning("Error connecting to irc: " + e);
} catch (IrcException e) {
LOGGER.warning("Error connecting to irc: " + e);
} catch (RuntimeException e) {
// JENKINS-17017: contrary to Javadoc PircBotx (at least 1.7 and 1.8) sometimes
// throw a RuntimeException instead of IOException if connecting fails
LOGGER.warning("Error connecting to irc: " + e);
}
return false;
}
Expand Down

0 comments on commit 3f3a6bd

Please sign in to comment.