[JENKINS-14491] NPE reported by Jesse Jacob.

Form binding apparently neglects to pass empty lists to data-bound constructors, so check for null. Reproducible even in 1.473 just by configuring publisher with no rows, i.e. not actually the real problem reported in this bug (though made more apparent by it).
jenkinsci · Jul 30, 2012 · d3d2415 · d3d2415 · mrooney · Aug 3, 2012
1 parent 24bebc0
commit d3d2415
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/main/java/htmlpublisher/HtmlPublisher.java b/src/main/java/htmlpublisher/HtmlPublisher.java
@@ -57,7 +57,7 @@ public class HtmlPublisher extends Recorder {
 
     @DataBoundConstructor
     public HtmlPublisher(List<HtmlPublisherTarget> reportTargets) {
-        this.reportTargets = new ArrayList<HtmlPublisherTarget>(reportTargets);
+        this.reportTargets = reportTargets != null ? new ArrayList<HtmlPublisherTarget>(reportTargets) : new ArrayList<HtmlPublisherTarget>();
     }
 
     public ArrayList<HtmlPublisherTarget> getReportTargets() {