[JENKINS-17807] no need to check for null jobs, just their results

jenkinsci · Mar 19, 2014 · 62bd18e · 62bd18e
1 parent 8ce67f5
commit 62bd18e
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/main/java/hockeyapp/HockeyappRecorder.java b/src/main/java/hockeyapp/HockeyappRecorder.java
@@ -261,16 +261,14 @@ public Collection<? extends Action> getProjectActions(
 			AbstractProject<?, ?> project) {
 		ArrayList<HockeyappBuildAction> actions = new ArrayList<HockeyappBuildAction>();
 		RunList<? extends AbstractBuild<?, ?>> builds = project.getBuilds();
-		
+
 		@SuppressWarnings("unchecked")
 		Collection<AbstractBuild<?, ?>> predicated = CollectionUtils.select(builds, new Predicate() {
 			public boolean evaluate(Object o) {
-				if(o == null || ((AbstractBuild<?, ?>) o).getResult() == null) {
-					return false;
-				} else {
-					return ((AbstractBuild<?, ?>) o).getResult().isBetterOrEqualTo(
-							Result.SUCCESS);
-				}
+				Result r = ((AbstractBuild<?,?>) o).getResult();
+				return r == null // no result yet
+					? false
+					: r.isBetterOrEqualTo(Result.SUCCESS);
 			}
 		});