[JENKINS-32007] Code review comments

jenkinsci · Mar 3, 2017 · 2f2a2e1 · 2f2a2e1
1 parent a29651d
commit 2f2a2e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/FillErrorResponse.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/FillErrorResponse.java
@@ -28,7 +28,7 @@ public void generateResponse(StaplerRequest req, StaplerResponse rsp, Object nod
         rsp.setContentType("text/html;charset=UTF-8");
         rsp.setHeader("X-Jenkins-Select-Error", clearList ? "clear" : "retain");
         rsp.getWriter().print(
-                "<div class=" + "error".toLowerCase(Locale.ENGLISH) + "><img src=\'" + req.getContextPath()
+                "<div class=\'error\'><img src=\'" + req.getContextPath()
                         + Jenkins.RESOURCE_PATH + "/images/none.gif\' height=16 width=1>" + Util.escape(message) +
                         "</div>");
 

diff --git a/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java b/src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
@@ -1326,6 +1326,7 @@ public ListBoxModel doFillRepositoryItems(@CheckForNull @AncestorInPath Item con
                                             ? "anonymous access"
                                             : CredentialsNameProvider.name(credentials)
                             });
+                            LOGGER.log(lr);
                             throw new FillErrorResponse(e.getMessage(), false);
                         }
                         if (myself != null && repoOwner.equalsIgnoreCase(myself.getLogin())) {
@@ -1352,6 +1353,7 @@ public ListBoxModel doFillRepositoryItems(@CheckForNull @AncestorInPath Item con
                                         ? "anonymous access"
                                         : CredentialsNameProvider.name(credentials)
                         });
+                        LOGGER.log(lr);
                         throw new FillErrorResponse(e.getMessage(), false);
                     }
                     if (org != null && repoOwner.equalsIgnoreCase(org.getLogin())) {
@@ -1383,6 +1385,7 @@ public ListBoxModel doFillRepositoryItems(@CheckForNull @AncestorInPath Item con
                                         ? "anonymous access"
                                         : CredentialsNameProvider.name(credentials)
                         });
+                        LOGGER.log(lr);
                         throw new FillErrorResponse(e.getMessage(), false);
                     }
                     if (user != null && repoOwner.equalsIgnoreCase(user.getLogin())) {