[JENKINS-44271] doFillcredentialsId to look for Item not SCMSourceOwner.

The method GitSCMSource.DescriptorImpl#doFillCredentialsIdItems expects the parameter 'context' to be an SCMSourceOwner which breaks the ability to add a global library at the level of a folder with the modern SCM implementation. Changing the parameter type from SCMSourceOwner to Item solves the issue.
jenkinsci · Jul 26, 2017 · 9841317 · 9841317
1 parent 5b31a94
commit 9841317
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/jenkins/plugins/git/GitSCMSource.java b/src/main/java/jenkins/plugins/git/GitSCMSource.java
@@ -424,7 +424,7 @@ public String getDisplayName() {
             return Messages.GitSCMSource_DisplayName();
         }
 
-        public ListBoxModel doFillCredentialsIdItems(@AncestorInPath SCMSourceOwner context,
+        public ListBoxModel doFillCredentialsIdItems(@AncestorInPath Item context,
                                                      @QueryParameter String remote,
                                                      @QueryParameter String credentialsId) {
             if (context == null && !Jenkins.getActiveInstance().hasPermission(Jenkins.ADMINISTER) ||
@@ -441,8 +441,8 @@ public ListBoxModel doFillCredentialsIdItems(@AncestorInPath SCMSourceOwner cont
                             GitClient.CREDENTIALS_MATCHER)
                     .includeCurrentValue(credentialsId);
         }
-
-        public FormValidation doCheckCredentialsId(@AncestorInPath SCMSourceOwner context,
+        
+        public FormValidation doCheckCredentialsId(@AncestorInPath Item context,
                                                    @QueryParameter String remote,
                                                    @QueryParameter String value) {
             if (context == null && !Jenkins.getActiveInstance().hasPermission(Jenkins.ADMINISTER) ||