[Fix JENKINS-27180] GIT_COMMIT env var not allowed with empty value

Only place GIT_COMMIT into the environment if it has a non-empty value. An empty value in the environment is assumed to have no significant difference from a non-existing value.
jenkinsci · Jul 21, 2015 · 90a0d7c · lanwen · Aug 17, 2015 · 90a0d7c
1 parent c1872d0
commit 90a0d7c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/main/java/hudson/plugins/git/GitSCM.java b/src/main/java/hudson/plugins/git/GitSCM.java
@@ -1175,7 +1175,10 @@ public void buildEnvVars(AbstractBuild<?, ?> build, java.util.Map<String, String
                 }
             }
 
-            env.put(GIT_COMMIT, fixEmpty(rev.getSha1String()));
+            String sha1 = fixEmpty(rev.getSha1String());
+            if (sha1 != null && !sha1.isEmpty()) {
+                env.put(GIT_COMMIT, sha1);
+            }
         }