Fix JENKINS-33695 by reverting "Fix GitSCM findbugs serialization war…

…nings" This reverts commit bb6f686 and fixes JENKINS-33695. The serialization of extensions is critical to preserving the settings when saving the job. Most embarrassing that my interactive testing prior to release of git plugin 2.4.3 did not detect the problem.
jenkinsci · Mar 23, 2016 · 7f21ab8 · 7f21ab8
1 parent 8bb7927
commit 7f21ab8
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/main/java/hudson/plugins/git/GitSCM.java b/src/main/java/hudson/plugins/git/GitSCM.java
@@ -126,7 +126,7 @@ public class GitSCM extends GitSCMBackwardCompatibility {
     /**
      * All the configured extensions attached to this.
      */
-    private transient DescribableList<GitSCMExtension,GitSCMExtensionDescriptor> extensions;
+    private DescribableList<GitSCMExtension,GitSCMExtensionDescriptor> extensions;
 
     public Collection<SubmoduleConfig> getSubmoduleCfg() {
         return submoduleCfg;
@@ -893,9 +893,8 @@ public AbstractBuild<?,?> getBySHA1(String sha1) {
     }
 
     /*package*/ static class BuildChooserContextImpl implements BuildChooserContext, Serializable {
-        private static final long serialVersionUID = 1L;
-        final transient Job project;
-        final transient Run build;
+        final Job project;
+        final Run build;
         final EnvVars environment;
 
         BuildChooserContextImpl(Job project, Run build, EnvVars environment) {