[JENKINS-8365] avoid unbounded memory consumption with a massive change.

jenkinsci · Jul 12, 2011 · 6cfb790 · 6cfb790
1 parent 46a2670
commit 6cfb790
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/main/java/hudson/plugins/git/GitChangeLogParser.java b/src/main/java/hudson/plugins/git/GitChangeLogParser.java
@@ -49,8 +49,8 @@ public GitChangeSetList parse(AbstractBuild build, File changelogFile)
                     lines = new ArrayList<String>();
                 }
 
-                if (lines != null)
-                    lines.add(line);
+                if (lines != null && lines.size()<THRESHOLD)
+                    lines.add(line);    // TODO: if we ignored some lines, tell the user so.
             }
 
             if (lines != null) {
@@ -67,5 +67,9 @@ public GitChangeSetList parse(AbstractBuild build, File changelogFile)
     private GitChangeSet parseCommit(List<String> lines, boolean authorOrCommitter) {
         return new GitChangeSet(lines, authorOrCommitter);
     }
-
+
+    /**
+     * To control the memory overhead of a large change, we ignore beyond certain number of lines.
+     */
+    private static int THRESHOLD = 1000;
 }