Merge pull request #545 from stephenc/no-double-negative-config

[FIXED JENKINS-45822] Swap semantics of 'Do not fetch tags' to 'Fetch tags'
jenkinsci · Oct 23, 2017 · 0bd7751 · 0bd7751
2 parents d4703a4 + a406c54
commit 0bd7751
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/config.groovy b/src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/config.groovy
@@ -2,18 +2,18 @@ package hudson.plugins.git.extensions.impl.CloneOption;
 
 def f = namespace(lib.FormTagLib);
 
+f.entry(title:_("Fetch tags"), field:"noTags") {
+    f.checkbox(negative:true, checked:(instance==null||!instance.noTags))
+}
+f.entry(title:_("Honor refspec on initial clone"), field:"honorRefspec") {
+    f.checkbox()
+}
 f.entry(title:_("Shallow clone"), field:"shallow") {
     f.checkbox()
 }
 f.entry(title:_("Shallow clone depth"), field:"depth") {
     f.number(clazz:"number", min:1, step:1)
 }
-f.entry(title:_("Do not fetch tags"), field:"noTags") {
-	f.checkbox()
-}
-f.entry(title:_("Honor refspec on initial clone"), field:"honorRefspec") {
-	f.checkbox()
-}
 f.entry(title:_("Path of the reference repo to use during clone"), field:"reference") {
     f.textbox()
 }

diff --git a/src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-noTags.html b/src/main/resources/hudson/plugins/git/extensions/impl/CloneOption/help-noTags.html
@@ -1,4 +1,4 @@
 <div>
-  Perform a clone without tags, saving time and disk space when you just want to access
+  Deselect this to perform a clone without tags, saving time and disk space when you just want to access
   what is specified by the refspec.
 </div>