Merge pull request #235 from cyrille-leclerc/JENKINS-37899

[JENKINS-37899] RemoteGitImpl: Take a snapshot of the credentials before passing them to the git client proxy
jenkinsci · Feb 26, 2017 · e75b299 · e75b299
2 parents 196ed5d + 0381412
commit e75b299
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/gitclient/RemoteGitImpl.java b/src/main/java/org/jenkinsci/plugins/gitclient/RemoteGitImpl.java
@@ -1,5 +1,6 @@
 package org.jenkinsci.plugins.gitclient;
 
+import com.cloudbees.plugins.credentials.CredentialsProvider;
 import com.cloudbees.plugins.credentials.common.StandardCredentials;
 import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials;
 import edu.umd.cs.findbugs.annotations.NonNull;
@@ -196,17 +197,17 @@ public void clearCredentials() {
 
     /** {@inheritDoc} */
     public void addCredentials(String url, StandardCredentials credentials) {
-        proxy.addCredentials(url, credentials); // credentials are Serializable
+        proxy.addCredentials(url, CredentialsProvider.snapshot(StandardCredentials.class, credentials)); // credentials are Serializable
     }
 
     /** {@inheritDoc} */
     public void setCredentials(StandardUsernameCredentials cred) {
-        proxy.setCredentials(cred);
+        proxy.setCredentials(CredentialsProvider.snapshot(StandardUsernameCredentials.class, cred)); // credentials are Serializable
     }
 
     /** {@inheritDoc} */
     public void addDefaultCredentials(StandardCredentials credentials) {
-        proxy.addDefaultCredentials(credentials); // credentials are Serializable
+        proxy.addDefaultCredentials(CredentialsProvider.snapshot(StandardCredentials.class, credentials)); // credentials are Serializable
     }
 
     /** {@inheritDoc} */