[FIXED JENKINS-20326] proxy may not require authentication

jenkinsci · Oct 29, 2013 · 8512c51 · 8512c51
1 parent 1b7fd2b
commit 8512c51
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java b/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
@@ -1414,7 +1414,8 @@ private String getURLWithCrendentials(URIish u, StandardCredentials cred) {
 
             if (proxy != null) {
                 client.getHostConfiguration().setProxy(proxy.name, proxy.port);
-                client.getState().setProxyCredentials(AuthScope.ANY, new UsernamePasswordCredentials(proxy.getUserName(), proxy.getPassword()));
+                if (proxy.getUserName() != null && proxy.getPassword() != null)
+                    client.getState().setProxyCredentials(AuthScope.ANY, new UsernamePasswordCredentials(proxy.getUserName(), proxy.getPassword()));
             }
 
             List<String> candidates = new ArrayList<String>();