[Fix JENKINS-28943] Find windows ssh even if git is absolute path to …

…cmd dir The path guesser in getPathToExe correctly checks for cmd and exe suffixes, and correctly checks each entry in the PATH environment variable. Prior to this change, it did not check for the absolute path having been specified with the cmd directory rather than the bin directory. The user had set C:\Program Files\Git\cmd\git.exe as the git program for that slave. That is an allowed setting, and it executed most git commands correctly. It failed on ssh based commands.
jenkinsci · Jun 20, 2015 · 3e5ad16 · 3e5ad16
1 parent f4d2340
commit 3e5ad16
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java b/src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
@@ -1463,6 +1463,11 @@ private String getPathToExe(String userGitExe) {
             }
         }
 
+        File userGitFile = new File(userGitExe);
+        if (userGitFile.exists()) {
+            return userGitFile.getAbsolutePath();
+        }
+
         return null;
     }